Bug 3978 – squidGuard not working anymore with squid 3.4.1

Bug 3978 - squidGuard not working anymore with squid 3.4.1


Summary:	squidGuard not working anymore with squid 3.4.1

Status:	RESOLVED WONTFIX

Product:	Squid
Classification:	Unclassified
Component:	other
Version:	3.4
Hardware:	All Unix - All

Importance:	P2 minor
Target Milestone:	---
Assigned To:	SQUID BUGS ALIAS

URL:

Duplicates:	3979 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-12-10 08:56 UTC by TAU
Modified:	2014-05-01 14:21 UTC (History)
CC List:	2 users (show)

See Also:
Browser:	---
Fixed Versions:

Attachments
Update SquidGuard to supply Squid 3.4 updated helper protocol (2.56 KB, patch) 2013-12-11 06:16 UTC, Amos Jeffries	Details
Update squdigaurd 1.5beta to supply squid-3.4 updated helper protocol (4.26 KB, patch) 2013-12-11 22:58 UTC, Amos Jeffries	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description TAU 2013-12-10 08:56:31 UTC

Hi,

FYI, Since the change of url_rewrite_program response format, squiguard (1.4) is not filtering forbidden content anymore.

In cache.log I have the following lines :

2013/12/09 11:40:06 kid1| UPGRADE WARNING: URL rewriter reponded with garbage ' - GET'. Future Squid will treat this as part of the URL.
2013/12/09 11:40:06 kid1| ERROR: URL-rewrite produces invalid request: GET 172.16.182.82/- - GET HTTP1.1

Last version of squidguard is 2009, I know it is a little bit old now. I have downgraded my test server to 3.3.11 to get filtering back, not a big deal for the moment.

Regards,

TAU

Comment 1 Amos Jeffries 2013-12-10 12:48:40 UTC

I am closing this as WONTFIX because the bug here is not in Squid but in squidGuard incorrect use of Squid helper protocol. I am not talking the new protocol either, SG was incorrectly using the _old_ squid-2.5 protocol.

The Squid behaviour here is exactly as it was before the new protocol:
  The response causes redirection to break and no change is performed on that transaction.

The error you are seeing is not new either. 3.2 and later should have all been showing similar errors with that squidGuard output.

Comment 2 Amos Jeffries 2013-12-10 20:34:02 UTC

*** Bug 3979 has been marked as a duplicate of this bug. ***

Comment 3 Amos Jeffries 2013-12-11 06:16:08 UTC

Created attachment 2988 [details]
Update SquidGuard to supply Squid 3.4 updated helper protocol

This is a patch for squidGuard-1.4 to make it output the new helper protocol and avoid these errors.

Comment 4 Salvador 2013-12-11 14:46:52 UTC

(In reply to comment #3)
> Created attachment 2988 [details]
> Update SquidGuard to supply Squid 3.4 updated helper protocol
> 
> This is a patch for squidGuard-1.4 to make it output the new helper protocol
> and avoid these errors.

Thanks you very much Amos , i was about to install squidGuard 1.5 beta to see if corrects that behavior , we will try your patch and post results later ..

Once again thanks so much Amos and happy holidays...

Comment 5 Amos Jeffries 2013-12-11 22:58:43 UTC

Created attachment 2989 [details]
Update squdigaurd 1.5beta to supply squid-3.4 updated helper protocol

This is the earlier patch ported to squdiGuard 1.5beta

Comment 6 TAU 2013-12-13 15:54:45 UTC

(In reply to comment #3)
> Created attachment 2988 [details]
> Update SquidGuard to supply Squid 3.4 updated helper protocol
> 
> This is a patch for squidGuard-1.4 to make it output the new helper protocol
> and avoid these errors.

Hi,

squidGuard 1.4 Patch installed with a 3.4.1 squid.
I confirm that It is running like a charm, can't browse bonjourmadame.fr anymore !

Thanks for the quick fix Amos !

Regards,

TAU

Comment 7 Dagobert Michelsen 2014-05-01 14:21:09 UTC

Also the test suite results need adjustment. I used
 cd test && perl -i.orig -npe 'if(/^$/){s/^$/ERR/}else{s/([^ ]*).*/OK rewrite-url="$1"/}' test1.expected test2.expected